Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add base management command for projects #73

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Add base management command for projects #73

merged 4 commits into from
Oct 30, 2023

Conversation

c0rydoras
Copy link
Collaborator

No description provided.

@c0rydoras c0rydoras added backend This issue or pull request is backend related enhancement This issue or pull request discusses non feature changes labels Aug 28, 2023
@c0rydoras c0rydoras self-assigned this Aug 28, 2023
@c0rydoras c0rydoras linked an issue Aug 28, 2023 that may be closed by this pull request
Project Base Management Command #62
Closed
@c0rydoras c0rydoras force-pushed the django-base-project-command branch 3 times, most recently from f44333f to 02ec3f6 Compare September 5, 2023 09:16
@c0rydoras c0rydoras mentioned this pull request Oct 24, 2023
Draft
@c0rydoras c0rydoras force-pushed the django-base-project-command branch 4 times, most recently from cc75a69 to 6033236 Compare October 30, 2023 09:54
open-dynaMIX
open-dynaMIX requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@open-dynaMIX open-dynaMIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👍

Regarding commit names, it would be nice if they would more reflect a reasoning. For example the commit refacor(api): drop async in synchronizer: When reading the code change it's clear what was done. What's unclear is why was it done.

api/outdated/tests/test_commands.py Outdated Show resolved Hide resolved
api/outdated/commands.py Outdated Show resolved Hide resolved
@c0rydoras c0rydoras force-pushed the django-base-project-command branch 2 times, most recently from 4c6e7b7 to 07a7879 Compare October 30, 2023 11:30
@c0rydoras c0rydoras force-pushed the django-base-project-command branch 3 times, most recently from fc22aac to 1ce83b6 Compare October 30, 2023 11:42
open-dynaMIX
open-dynaMIX requested changes Oct 30, 2023
View reviewed changes
api/outdated/commands.py Outdated Show resolved Hide resolved
@c0rydoras c0rydoras merged commit f6c1fc3 into adfinis:main Oct 30, 2023
4 checks passed
@c0rydoras c0rydoras deleted the django-base-project-command branch October 30, 2023 12:40
@c0rydoras c0rydoras mentioned this pull request Nov 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@open-dynaMIX open-dynaMIX open-dynaMIX approved these changes

Assignees

@c0rydoras c0rydoras

Labels
backend This issue or pull request is backend related enhancement This issue or pull request discusses non feature changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Project Base Management Command
2 participants
@c0rydoras @open-dynaMIX